[JavaScript] Add Bot Authentication SNI sample bot #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested changes
Oct 10, 2023
README.md
Outdated
| @@ -185,6 +186,7 @@ A [collection of **experimental** samples](./experimental) exist, intended to pr | |||
| [js#81]:samples/javascript_nodejs/81.skills-skilldialog | |||
| [js#82]:samples/javascript_nodejs/82.skills-sso-cloudadapter | |||
| [js#84]:samples/javascript_nodejs/84.bot-authentication-certificate | |||
| [js#85]:samples/javascript_nodejs/84.bot-authentication-sni | |||
There was a problem hiding this comment.
Change this to the right sample number.
| ``` | ||
|
|
||
| 1. Then, type _Manage User Certificates_ in the Windows search bar and hit enter | ||
| 2. The certificate will be in the _user certificates_ folder, under _personal_. |
There was a problem hiding this comment.
Suggested change
| 2. The certificate will be in the _user certificates_ folder, under _personal_. | |
| 2. The certificate will be located in the _user certificates_ folder, under _personal_ directory. |
| 1. Run the following command in a local PowerShell | ||
|
|
||
| ``` | ||
| $cert = New-SelfSignedCertificate -CertStoreLocation "Cert:\CurrentUser\My" -Subject "CN=sampleAppCert" -KeySpec KeyExchange |
There was a problem hiding this comment.
Here we should use tags to let the users know which values they need to provide. For example:
Suggested change
| $cert = New-SelfSignedCertificate -CertStoreLocation "Cert:\CurrentUser\My" -Subject "CN=sampleAppCert" -KeySpec KeyExchange | |
| $cert = New-SelfSignedCertificate -CertStoreLocation "<directory-to-store-certificate>" -Subject "CN=<certificate-name>" -KeySpec KeyExchange |
| 4. Go to the certificate location and run the following command to generate a _pem_ file: | ||
|
|
||
| ``` | ||
| OpenSSL pkcs12 -in sampleAppCert.pfx -out c:\sampleAppCert.pem –nodes |
| 2. Under the Certificates section, hit on Generate/Import, complete the form, and create the certificate in PEM format. | ||
| 3. Go to the details of the certificate that you created and enable it. | ||
| 4. Download the certificate in CER format and then upload it to the Azure app registration. | ||
|
|
There was a problem hiding this comment.
We should add a section indicating which values to set in the bot's .env file.
| "@azure/identity": "^3.3.0", | ||
| "@azure/keyvault-certificates": "^4.7.0", | ||
| "@azure/keyvault-secrets": "^4.7.0", | ||
| "botbuilder": "~4.20.0", |
There was a problem hiding this comment.
Should we target version 4.21.0? It's not published yet, but version 4.20 doesn't contain the MSAL support this sample needs.
There was a problem hiding this comment.
Or maybe we should use the ^ symbol.
ceciliaavila
requested changes
Oct 10, 2023
Comment on lines
17
to
18
|
|
||
|
|
| @@ -1,6 +1,4 @@ | |||
| MicrosoftAppType= | |||
There was a problem hiding this comment.
I think we should keep the AppType at least. This should work for singletenant.
ceciliaavila
approved these changes
Oct 10, 2023
sw-joelmut
approved these changes
Oct 10, 2023
|
Promoted to 3914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR adds a new sample for Javascript_nodejs that shows how to authenticate the Azure bot using the Subject Name/Issuer from MSAL.
Proposed Changes
Testing
This image shows the new bot-authentication-sni sample working.
